fix: Change plan order in case of used SG rename #339
Conversation
|
This PR has been automatically marked as stale because it has been open 30 days |
madpipeline
changed the title
|
@antonbabenko can you please review this? |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
This is still an issue. If this is not the proper solution for this, please let me know, so we can try to come up with something better. |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Bumping. Still hoping for an answer. |
| var.tags, | ||
| ) | ||
|
|
||
| lifecycle { |
There was a problem hiding this comment.
this is not valid the way its currently written - you would face an error of a resource already existing with the same name (cannot have two security groups with the same name). This would only be possible if name_prefix was used to ensure the two groups could co-exist for a short period of time
There was a problem hiding this comment.
If name_prefix is used the issue this PR is trying to resolve would not exist in the first place.
Description
If a SG is created and used by another resource, and a rename of the SG is required, this is only possible with recreating the using resource as well or by adding this lifecycle rule to the SG.
Motivation and Context
Described above.
Breaking Changes
None.
How Has This Been Tested?
Tested by locally updating the module and deploying.
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request